linux-kernel - Re: [PATCH] selinuxfs: Fix sel_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhQ7VinEbxX71ZALL7aSqyRej3OixCKKtOVa9uSQ5XFwpA@mail.gmail.com>
Date:	Thu, 26 Mar 2015 06:08:01 -0400
From:	Paul Moore <paul@...l-moore.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Stephen Smalley <sds@...ho.nsa.gov>,
	Eric Paris <eparis@...isplace.org>,
	James Morris <james.l.morris@...cle.com>,
	"Serge E. Hallyn" <serge@...lyn.com>, selinux@...ho.nsa.gov,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selinuxfs: Fix sel_write_enforce broken return value

Mon, Mar 23, 2015 at 9:01 PM, Joe Perches <joe@...ches.com> wrote:
> Return a negative error value like the rest
> of the entries in this function.
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
> Maybe this should be stable, it goes back to
> commit b77a493b1dc8 ("SELinux: standardize return code
> handling in selinuxfs.c") back in Nov 2010, but it's
> guarded by a #ifdef CONFIG_SECURITY_SELINUX_DEVELOP
> so it probably doesn't matter much.
>
>  security/selinux/selinuxfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

My apologies, I hit reply and not reply-all to Stephen's ACK
mentioning that it might take me a day or two to merge this ...
regardless, it's merged now and marked for -stable; I also just sent a
pull request to James with this patch for v3.20.

Thanks for the fix.

> diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
> index 1684bcc..5fde343 100644
> --- a/security/selinux/selinuxfs.c
> +++ b/security/selinux/selinuxfs.c
> @@ -152,7 +152,7 @@ static ssize_t sel_write_enforce(struct file *file, const char __user *buf,
>                 goto out;
>
>         /* No partial writes. */
> -       length = EINVAL;
> +       length = -EINVAL;
>         if (*ppos != 0)
>                 goto out;
>
>
>



-- 
paul moore
www.paul-moore.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/