linux-kernel - Re: [V6 PATCH 2/3] ACPI / scan: Add support for ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Mar 2015 09:39:48 -0500
From:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
CC:	<rjw@...ysocki.net>, <robert.moore@...el.com>,
	<lv.zheng@...el.com>, <lenb@...nel.org>, <hdegoede@...hat.com>,
	<tj@...nel.org>, <mjg59@...f.ucam.org>,
	<gregkh@...uxfoundation.org>, <hanjun.guo@...aro.org>,
	<al.stone@...aro.org>, <graeme.gregory@...aro.org>,
	<leo.duran@....com>, <linux-ide@...r.kernel.org>,
	<linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linaro-acpi@...ts.linaro.org>
Subject: Re: [V6 PATCH 2/3] ACPI / scan: Add support for ACPI _CLS device
 matching



On 3/26/15 05:29, Mika Westerberg wrote:
> On Wed, Mar 25, 2015 at 03:46:07PM -0500, Suravee Suthikulpanit wrote:
>> [...]
>> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
>> index e530533..9563abe 100644
>> --- a/include/linux/mod_devicetable.h
>> +++ b/include/linux/mod_devicetable.h
>> @@ -189,8 +189,12 @@ struct css_device_id {
>>   struct acpi_device_id {
>>   	__u8 id[ACPI_ID_LEN];
>>   	kernel_ulong_t driver_data;
>> +	__u32 cls;
>> +	__u32 cls_msk;
>>   };
>>
>> +#define ACPI_DEVICE_CLASS(cls, msk)		"", 0, cls, msk
>
> Consider moving this to <linux/acpi.h>, just like PCI_DEVICE_CLASS() is
> defined in <linux/pci.h>.
>
> Also please use designated initializers here, eg:
>
> #define ACPI_DEVICE_CLASS(cls, msk)	.cls = (cls), .cls_mask = (msk)
>
> Once done you can add my,
>
> Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Ah right. I should have done that. I'll send out V7 with this change and 
acked-by.

Thanks,
Suravee
>
>> +
>>   #define PNP_ID_LEN	8
>>   #define PNP_MAX_DEVICES	8
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/