linux-kernel - Re: [PATCH] c6x: include: asm: dma-mapping: Add dummy dma_sync_single_range_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1427381842.9430.46.camel@deneb.redhat.com>
Date:	Thu, 26 Mar 2015 10:57:22 -0400
From:	Mark Salter <msalter@...hat.com>
To:	Chen Gang <xili_gchen_5257@...mail.com>
Cc:	a-jacquiot@...com, linux-c6x-dev@...ux-c6x.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] c6x: include: asm: dma-mapping: Add dummy
 dma_sync_single_range_for_device

On Wed, 2015-03-04 at 11:09 +0800, Chen Gang wrote:
> c6x does not implement get_dma_ops() for dma-mapping-common.h. And in
> dma-mapping-common.h, dma_sync_single_range_for_device() may be dummy.
> So c6x can just define a dummy function for allmodconfig building.
> 
>     CC [M]  drivers/net/ethernet/micrel/ks8851.o
>   drivers/net/ethernet/micrel/ks8842.c: In function 'ks8842_tx_frame_dma':
>   drivers/net/ethernet/micrel/ks8842.c:453:2: error: implicit declaration of function 'dma_sync_single_range_for_device' [-Werror=implicit-function-declaration]
>     dma_sync_single_range_for_device(adapter->dev,
>     ^
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> ---

Thanks! I added this to the c6x tree for next merge window.

>  arch/c6x/include/asm/dma-mapping.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/c6x/include/asm/dma-mapping.h b/arch/c6x/include/asm/dma-mapping.h
> index 88bd0d8..bbd7774 100644
> --- a/arch/c6x/include/asm/dma-mapping.h
> +++ b/arch/c6x/include/asm/dma-mapping.h
> @@ -17,6 +17,14 @@
>  
>  #define dma_supported(d, m)	1
>  
> +static inline void dma_sync_single_range_for_device(struct device *dev,
> +						    dma_addr_t addr,
> +						    unsigned long offset,
> +						    size_t size,
> +						    enum dma_data_direction dir)
> +{
> +}
> +
>  static inline int dma_set_mask(struct device *dev, u64 dma_mask)
>  {
>  	if (!dev->dma_mask || !dma_supported(dev, dma_mask))


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/