linux-kernel - Re: [patch 1/4] fs, jfs: remove slab object constructor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55141E75.4090403@oracle.com>
Date:	Thu, 26 Mar 2015 09:57:57 -0500
From:	Dave Kleikamp <dave.kleikamp@...cle.com>
To:	Christoph Hellwig <hch@....de>,
	David Rientjes <rientjes@...gle.com>
CC:	Mikulas Patocka <mpatocka@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dave Kleikamp <shaggy@...nel.org>,
	Sebastian Ott <sebott@...ux.vnet.ibm.com>,
	Catalin Marinas <catalin.marinas@....com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	jfs-discussion@...ts.sourceforge.net
Subject: Re: [patch 1/4] fs, jfs: remove slab object constructor

On 03/26/2015 02:28 AM, Christoph Hellwig wrote:
> On Wed, Mar 25, 2015 at 07:37:40PM -0700, David Rientjes wrote:
>> That would be true only for
>>
>> 	ptr = mempool_alloc(gfp, pool);
>> 	mempool_free(ptr, pool);
>>
>> and nothing in between, and that's pretty pointless.  Typically, callers 
>> allocate memory, modify it, and then free it.  When that happens with 
>> mempools, and we can't allocate slab because of the gfp context, mempools 
>> will return elements in the state in which they were freed (modified, not 
>> as constructed).
> 
> The historic slab allocator (Solaris and early Linux) expects objects
> to be returned in the same / similar enough form as the constructor
> returned it, and the constructor is only called when allocating pages
> from the page pool.

I'm pretty sure that this was the intention of the jfs code. Returned
objects should have these fields returned to their initial values. It
does seem error-prone, though. If jfs is in fact the last user of the
constructor, it's probably time for it to die.

> 
> I have to admit that I haven't used this feature forever, and I have no idea if
> people changed how the allocator works in the meantime.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/