linux-kernel - Re: [PATCH 2/3] x86: add a is_e820

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150326164314.GB23958@lst.de>
Date:	Thu, 26 Mar 2015 17:43:14 +0100
From:	Christoph Hellwig <hch@....de>
To:	Boaz Harrosh <boaz@...xistor.com>
Cc:	Christoph Hellwig <hch@....de>, Ingo Molnar <mingo@...nel.org>,
	linux-nvdimm@...1.01.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, x86@...nel.org,
	ross.zwisler@...ux.intel.com, axboe@...nel.dk
Subject: Re: [PATCH 2/3] x86: add a is_e820_ram() helper

On Thu, Mar 26, 2015 at 05:49:38PM +0200, Boaz Harrosh wrote:
> > +	memmap=nn[KMG]!ss[KMG]
> > +			[KNL,X86] Mark specific memory as protected.
> > +			Region of memory to be used, from ss to ss+nn.
> > +			The memory region may be marked as e820 type 12 (0xc)
> > +			and is NVDIMM or ADR memory.
> > +
> 
> Do we need to escape "\!" this character on grub command line ? It might
> help to note that. I did like the original "|" BTW

No need to escape it on the kvm command line, which is where I tested
this flag only so far.  If there is a strong argument for "|" I'm happy
to change it.

> > +#define E820_PRAM	12
> 
> Why the PRAM Name. For one 2/3 of this patch say PMEM the Kconfig
> to enable is _PMEM_, the driver stack that gets loaded is pmem,
> so PRAM is unexpected.
> 
> Also I do believe PRAM is not the correct name. Yes NvDIMMs are RAM,
> but there are other not RAM technologies that can be supported exactly
> the same way.
> MEM is a more general name meaning "on the memory bus". I think.
> 
> I would love the consistency.

Ingo asked for the PRAM name, I don't really care either way.

> > +	case E820_PRAM:
> > +		printk(KERN_CONT "persistent (type %u)", type);
> 
> This case can only mean 12 in this patch. (I think historically
> you had a Kconfig to set its Number

Indeed.  I kept it in case people hack their kernels, but I can remove
it if people feel it's too ugly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/