linux-kernel - Re: [PATCH] arm: mach-omap2: remove superfluous NULL pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150326173417.GA10805@atomide.com>
Date:	Thu, 26 Mar 2015 10:34:19 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Stefan Agner <stefan@...er.ch>
Cc:	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, llvmlinux@...ts.linuxfoundation.org
Subject: Re: [PATCH] arm: mach-omap2: remove superfluous NULL pointer check

* Stefan Agner <stefan@...er.ch> [150321 17:00]:
> The NULL pointer check for superset->muxnames will always evaluate
> true since muxnames is an array within struct omap_mux. Remove the
> superfluous check to avoid warnings when using LLVM/clang.
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>

Applying into omap-for-v4.1/fixes-not-urgent thanks.

Tony

> ---
> For the reference, the warning generated by LLVM/clang:
> arch/arm/mach-omap2/mux.c:1056:18: warning: address of array
> 'superset->muxnames' will always evaluate to 'true' [-Wpointer-bool-conversion]
>                 if (!superset->muxnames || !superset->muxnames[0]) {
>                     ~~~~~~~~~~~^~~~~~~~
> 
>  arch/arm/mach-omap2/mux.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
> index 78064b0..176eef6 100644
> --- a/arch/arm/mach-omap2/mux.c
> +++ b/arch/arm/mach-omap2/mux.c
> @@ -1053,7 +1053,7 @@ static void __init omap_mux_init_list(struct omap_mux_partition *partition,
>  		struct omap_mux *entry;
>  
>  #ifdef CONFIG_OMAP_MUX
> -		if (!superset->muxnames || !superset->muxnames[0]) {
> +		if (!superset->muxnames[0]) {
>  			superset++;
>  			continue;
>  		}
> -- 
> 2.3.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/