linux-kernel - Re: [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150326183347.GY10964@mwanda>
Date:	Thu, 26 Mar 2015 21:33:47 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Niranjan Dighe <niranjan.dighe@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	charrer@...critech.com, liodot@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer
 variable

On Thu, Mar 26, 2015 at 11:52:43PM +0530, Niranjan Dighe wrote:
> Replace string directly in place of format string and remove pointer
> variable which was used just once.
> 
> Signed-off-by: Niranjan Dighe <niranjan.dighe@...il.com>
> 
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index c2bda1d..f3110f7 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -98,7 +98,6 @@
>  #include "slic.h"
>  
>  static uint slic_first_init = 1;
> -static char *slic_banner = "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)";
>  
>  static char *slic_proc_version = "2.0.351  2006/07/14 12:26:00";
>  
> @@ -3046,7 +3045,8 @@ static int slic_entry_probe(struct pci_dev *pcidev,
>  		return err;
>  
>  	if (did_version++ == 0) {
> -		dev_info(&pcidev->dev, "%s\n", slic_banner);
> +		dev_info(&pcidev->dev,
> +		"Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)\n");

This indenting looks ugly.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/