linux-kernel - Re: [PATCH v2 4/4] toshiba_bluetooth: Remove BT enable code from *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150326200024.GF19129@fury.dvhart.com>
Date:	Thu, 26 Mar 2015 13:00:24 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Azael Avalos <coproscefalo@...il.com>
Cc:	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] toshiba_bluetooth: Remove BT enable code from
 *_notify function

On Wed, Mar 25, 2015 at 04:18:19PM -0600, Azael Avalos wrote:
> > That suggests to me the checks for rfkill, powered, and plugged states should be
> > done in the _enable() function itself, rather than at all the call sites.
> >
> > So... would a better fix be to push these two additional tests into
> > toshiba_bluetooth_enable() before it calls AUSB and BTPO and then retain the
> > call the _enable() here?
> 
> Sure, I can apply these changes there.
> 
> What I wanted was to isolate what each call does as a preparation for
> upcoming patches where I will be purging toshiba_acpi from the BT
> RFKill code and add it to toshiba_bluetooth (where it belongs).

OK, I'll wait for v3 and pull it in. Thanks Azael.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/