linux-kernel - RE: [PATCH 7/7] ext4: add support for write stream IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Mar 2015 20:34:18 +0000
From:	Ming Lin-SSI <ming.l@....samsung.com>
To:	Jens Axboe <axboe@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
CC:	"david@...morbit.com" <david@...morbit.com>
Subject: RE: [PATCH 7/7] ext4: add support for write stream IDs

> -----Original Message-----
> From: Jens Axboe [mailto:axboe@...com]
> Sent: Wednesday, March 25, 2015 8:08 AM
> To: linux-kernel@...r.kernel.org; linux-fsdevel@...r.kernel.org
> Cc: Ming Lin-SSI; david@...morbit.com; Jens Axboe
> Subject: [PATCH 7/7] ext4: add support for write stream IDs
> 
> Signed-off-by: Jens Axboe <axboe@...com>
> ---
>  fs/ext4/page-io.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index
> b24a2541a9ba..f642d0b87a32 100644
> --- a/fs/ext4/page-io.c
> +++ b/fs/ext4/page-io.c
> @@ -390,6 +390,7 @@ submit_and_retry:
>  		ret = io_submit_init_bio(io, bh);
>  		if (ret)
>  			return ret;
> +		bio_set_streamid(io->io_bio, inode_streamid(inode));

For "writeback" and "ordered" journal mode, it should be OK.

But for "journal" journal mode, 
Step1: data written to journal
Step2: data written from journal to fs

Do we need other code to carry stream_id in step2?

Thanks,
Ming

>  	}
>  	ret = bio_add_page(io->io_bio, bh->b_page, bh->b_size,
> bh_offset(bh));
>  	if (ret != bh->b_size)
> --
> 1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/