linux-kernel - Re: [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427403153.15849.18.camel@perches.com>
Date:	Thu, 26 Mar 2015 13:52:33 -0700
From:	Joe Perches <joe@...ches.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Niranjan Dighe <niranjan.dighe@...il.com>,
	devel@...verdev.osuosl.org, charrer@...critech.com,
	liodot@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer
 variable

On Thu, 2015-03-26 at 19:52 +0100, Greg KH wrote:
> On Thu, Mar 26, 2015 at 11:52:43PM +0530, Niranjan Dighe wrote:
> > Replace string directly in place of format string and remove pointer
> > variable which was used just once.
[]
> > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
[]
> > @@ -3046,7 +3045,8 @@ static int slic_entry_probe(struct pci_dev *pcidev,
> >  		return err;
> >  
> >  	if (did_version++ == 0) {
> > -		dev_info(&pcidev->dev, "%s\n", slic_banner);
> > +		dev_info(&pcidev->dev,
> > +		"Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)\n");
> 
> Why make this change?  What's wrong with the original code?
> 
> There is the issue that driver should be quiet, so really, you can just
> delete all of this nonsense, but that's a different issue here...

You could also use dev_info_once instead.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/