linux-kernel - Re: [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1427406122.15849.22.camel@perches.com>
Date:	Thu, 26 Mar 2015 14:42:02 -0700
From:	Joe Perches <joe@...ches.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Niranjan Dighe <niranjan.dighe@...il.com>,
	devel@...verdev.osuosl.org, charrer@...critech.com,
	liodot@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer
 variable

On Thu, 2015-03-26 at 22:32 +0100, Greg KH wrote:
> On Thu, Mar 26, 2015 at 01:52:33PM -0700, Joe Perches wrote:
> > On Thu, 2015-03-26 at 19:52 +0100, Greg KH wrote:
> > > On Thu, Mar 26, 2015 at 11:52:43PM +0530, Niranjan Dighe wrote:
> > > > Replace string directly in place of format string and remove pointer
> > > > variable which was used just once.
> > []
> > > > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> > []
> > > > @@ -3046,7 +3045,8 @@ static int slic_entry_probe(struct pci_dev *pcidev,
> > > >  		return err;
> > > >  
> > > >  	if (did_version++ == 0) {
> > > > -		dev_info(&pcidev->dev, "%s\n", slic_banner);
> > > > +		dev_info(&pcidev->dev,
> > > > +		"Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)\n");
> > > 
> > > Why make this change?  What's wrong with the original code?
> > > 
> > > There is the issue that driver should be quiet, so really, you can just
> > > delete all of this nonsense, but that's a different issue here...
> > 
> > You could also use dev_info_once instead.
> 
> No, drivers shouldn't make any noise when loaded, or when bound to a
> device, that's just fluff that is not needed, and is why we made the
> default module load macros to help prevent that from happening.  Looks
> like people really wanted to be chatty here and tried to do it in their
> probe function instead :(
> 
> Just delete it.

There are many probe functions that emit messages
in the tree.  Most of the _once functions.

Maybe someone can delete those too.

$ git grep -E "\b[a-z_]+_once\s*\(.*(version|banner)" drivers
drivers/block/sx8.c:    printk_once(KERN_DEBUG DRV_NAME " version " DRV_VERSION "\n");
drivers/infiniband/hw/cxgb3/iwch.c:     printk_once(KERN_INFO MOD "Chelsio T3 RDMA Driver - version %s\n",
drivers/infiniband/hw/mlx4/main.c:      pr_info_once("%s", mlx4_ib_version);
drivers/infiniband/hw/mlx5/main.c:      printk_once(KERN_INFO "%s", mlx5_version);
drivers/infiniband/hw/mthca/mthca_main.c:       printk_once(KERN_INFO "%s", mthca_version);
drivers/infiniband/hw/usnic/usnic_ib_main.c:    printk_once(KERN_INFO "%s", usnic_version);
drivers/net/ethernet/8390/mac8390.c:    printk_once(KERN_INFO pr_fmt("%s"), version);
drivers/net/ethernet/amd/au1000_eth.c:  pr_info_once("%s version %s %s\n", DRV_NAME, DRV_VERSION, DRV_AUTHOR);
drivers/net/ethernet/broadcom/b44.c:    pr_info_once("%s version %s\n", DRV_DESCRIPTION, DRV_MODULE_VERSION);
drivers/net/ethernet/broadcom/tg3.c:    printk_once(KERN_INFO "%s\n", version);
drivers/net/ethernet/chelsio/cxgb/cxgb2.c:      pr_info_once("%s - version %s\n", DRV_DESCRIPTION, DRV_VERSION);
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:        pr_info_once("%s - version %s\n", DRV_DESC, DRV_VERSION);
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:        printk_once(KERN_INFO "%s - version %s\n", DRV_DESC, DRV_VERSION);
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c:    pr_info_once("%s - version %s\n", DRV_DESC, DRV_VERSION);
drivers/net/ethernet/cirrus/cs89x0.c:   pr_info_once("%s\n", version);
drivers/net/ethernet/dec/tulip/tulip_core.c:            printk_once(KERN_INFO "%s", version);
drivers/net/ethernet/mellanox/mlx4/en_main.c:   printk_once(KERN_INFO "%s", mlx4_en_version);
drivers/net/ethernet/mellanox/mlx4/main.c:      printk_once(KERN_INFO "%s", mlx4_version);
drivers/net/ethernet/realtek/8139cp.c:  pr_info_once("%s", version);
drivers/net/ethernet/smsc/epic100.c:    pr_info_once("%s%s\n", version, version2);
drivers/net/ethernet/smsc/smc9194.c:    pr_info_once("%s\n", version);
drivers/net/ethernet/smsc/smc91x.c:     pr_info_once("%s\n", version);
drivers/net/ethernet/sun/sungem.c:      printk_once(KERN_INFO "%s", version);
drivers/net/ethernet/sun/sunvnet.c:     printk_once(KERN_INFO "%s", version);
drivers/net/ethernet/via/via-rhine.c:   pr_info_once("%s\n", version);
drivers/net/wan/sbni.c: pr_info_once("%s", version);
drivers/net/wan/wanxl.c:        pr_info_once("%s\n", version);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/