lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Mar 2015 16:17:38 -0600 From: Ross Zwisler <ross.zwisler@...ux.intel.com> To: Boaz Harrosh <boaz@...xistor.com> Cc: Christoph Hellwig <hch@....de>, linux-nvdimm@...1.01.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org, axboe@...nel.dk Subject: Re: [PATCH] SQUASHME: Streamline pmem.c On Thu, 2015-03-26 at 19:02 +0200, Boaz Harrosh wrote: > Christoph why did you choose the fat and ugly version of > pmem.c beats me. Anyway, here are the cleanups you need on > top of your pmem patch. > > Among other it does: > * Remove getgeo. It is not needed for modern fdisk and was never > needed for libgparted and cfdisk. > > * remove 89 lines of code to do a single memcpy. The reason > this was so in brd (done badly BTW) is because destination > memory is page-by-page based. With pmem we have the destination > contiguous so we can do any size, in one go. > > * Remove SECTOR_SHIFT. It is defined in 6 other places > in the Kernel. I do not like a new one. 9 is used through > out, including block core. I do not like pmem to blasphemy > more than needed. > > * More style stuff ... > > Please squash into your initial submission > > Signed-off-by: Boaz Harrosh <boaz@...xistor.com> I agree with Christoph's comments, but overall I think these changes are great. Please send out as a series & you can add: Reviewed-by: Ross Zwisler <ross.zwisler@...ux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists