linux-kernel - Re: [PATCH V5 0/2] add support for pmic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 26 Mar 2015 23:51:01 +0100
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Kumar Gala <galak@...eaurora.org>
Cc:	"Ivan T. Ivanov" <iivanov@...sol.com>,
	Gilad Avidov <gavidov@...eaurora.org>, sdharia@...eaurora.org,
	mlocke@...eaurora.org, linux-arm-msm@...r.kernel.org,
	svarbanov@...sol.com, linux-kernel@...r.kernel.org,
	agross@...eaurora.org
Subject: Re: [PATCH V5 0/2] add support for pmic_arb v2 and correct framework

On Thu, Mar 26, 2015 at 10:26:09AM -0500, Kumar Gala wrote:
> 
> On Mar 26, 2015, at 4:51 AM, Ivan T. Ivanov <iivanov@...sol.com> wrote:
> 
> > 
> > On Wed, 2015-03-25 at 11:37 -0600, Gilad Avidov wrote:
> >> pmic_arb v2 has no support for spmi non-data commands and thus
> >> returns -EOPNOTSUPP on .cmd callback. This causes a failure in
> >> spmi_drv_probe() which sends a wakeup command to the slave before
> >> probing its driver. This patchset removes the wakeup from
> >> spmi_drv_probe() since the spmi spec stipulates that a slaves
> >> default state is active and doesn't need a wakeup.
> >> 
> >> Changes from v3 to v4:
> >> * Remove the claim that this is a bug fix off the commit text
> >> * Unmap the core register space as soon as we know that it will not be used
> >> * Assign the core reg space to a local until we know if it appropriate to use
> >>   it to configure the controller fields (on v1) or unmap it (on v2).
> >> 
> >> Changes from v4 to v5:
> >> * remove the unmap added in v4 since it is used again and the mapping is managed.
> >> * correct printf formatting for 64bit compilers.
> >> * correct base address for reading the channel table.
> >> 
> >> Gilad Avidov (2):
> >>  spmi: remove wakeup command before slave probe
> >>  spmi: pmic_arb: add support for hw version 2
> > 
> > Thank you Gilad. This is fine now. Tested on APQ8084
> > (controller v1) and MSM8916 (controller v2).
> > 
> > I am wandering which is the appropriate tree to merge this?
> > 
> > Kumar?
> 
> We’ve been asking Greg to pick up SPMI patches.

Yes, I can take them.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/