linux-kernel - Re: [PATCH] ftracetest: replace usleep by sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5513740A.6040500@draigBrady.com>
Date:	Thu, 26 Mar 2015 02:50:50 +0000
From:	Pádraig Brady <P@...igBrady.com>
To:	Steven Rostedt <rostedt@...dmis.org>,
	Luis Henriques <luis.henriques@...onical.com>
CC:	Shuah Khan <shuahkh@....samsung.com>,
	Namhyung Kim <namhyung@...nel.org>,
	linux-kernel@...r.kernel.org,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Subject: Re: [PATCH] ftracetest: replace usleep by sleep

On 25/03/15 18:57, Steven Rostedt wrote:
> On Wed, 25 Mar 2015 17:36:34 +0000
> Luis Henriques <luis.henriques@...onical.com> wrote:
> 
>> 'usleep' seems to be a distro-specific utility and may not be
>> available:
>>
>>  [5] event tracing - enable/disable with event level files       [FAIL]
>>  execute: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>>  + . /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>>  + [ ! -f set_event -o ! -d events/sched ]
>>  + reset_tracer
>>  + echo nop
>>  + do_reset
>>  + echo
>>  + clear_trace
>>  + echo
>>  + echo sched:sched_switch
>>  + usleep 1
>>  ./ftracetest: 24: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc: usleep: not found
>>
>> Replace it with the more standard sleep.
>>
>> Signed-off-by: Luis Henriques <luis.henriques@...onical.com>
>> ---
>>  tools/testing/selftests/ftrace/test.d/event/event-enable.tc     | 6 +++---
>>  tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 6 +++---
>>  2 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>> index 668616d9bb03..abafc0c3605c 100644
>> --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>> +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>> @@ -21,7 +21,7 @@ reset_tracer
>>  do_reset
>>  
>>  echo 'sched:sched_switch' > set_event
>> -usleep 1
>> +sleep 0.001
> 
> We had patches out about this, because sleep 0.001 is not always
> supported either.

really?
In that edge case you might:

  sleep .001 || sleep 1

Pádraig.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/