linux-kernel - [PATCH] kvm: vfio: fix fail to set error notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1427446123-11203-1-git-send-email-wanpeng.li@linux.intel.com>
Date:	Fri, 27 Mar 2015 16:48:43 +0800
From:	Wanpeng Li <wanpeng.li@...ux.intel.com>
To:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	Alex Williamson <alex.williamson@...hat.com>,
	Paolo Bonzini <pbonzini@...hat.com>,
	Wanpeng Li <wanpeng.li@...ux.intel.com>
Subject: [PATCH] kvm: vfio: fix fail to set error notification

After commit 6140a8f56238 ("vfio-pci: Add device request interface") merged,
there is error dump when run guest as below:

qemu-system-x86_64 -enable-kvm -m 2G -smp 2  -net none /root/cathy/rhel6u5.qcow -device vfio-pci,host=03:10.5
qemu-system-x86_64: -device vfio-pci,host=03:10.5: vfio: Failed to set up error notification

This is caused by missing one break, this patch fix it.

Reported-and-tested-by: Liu Rongrong <rongrongx.liu@...el.com>
Signed-off-by: Wanpeng Li <wanpeng.li@...ux.intel.com>
---
 drivers/vfio/pci/vfio_pci_intrs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
index f88bfdf..d1b6845 100644
--- a/drivers/vfio/pci/vfio_pci_intrs.c
+++ b/drivers/vfio/pci/vfio_pci_intrs.c
@@ -868,6 +868,7 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_device *vdev, uint32_t flags,
 				func = vfio_pci_set_err_trigger;
 			break;
 		}
+		break;
 	case VFIO_PCI_REQ_IRQ_INDEX:
 		switch (flags & VFIO_IRQ_SET_ACTION_TYPE_MASK) {
 		case VFIO_IRQ_SET_ACTION_TRIGGER:
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/