linux-kernel - Re: [PATCH v2] rculist: Fix another sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Mar 2015 02:49:43 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Ying Xue <ying.xue@...driver.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rculist: Fix another sparse warning

On Thu, Mar 26, 2015 at 01:27:08PM +0800, Ying Xue wrote:
> This fixes the following sparse warnings:
> 
> make C=1 CF=-D__CHECK_ENDIAN__ net/tipc/name_table.o
> net/tipc/name_table.c:977:17: error: incompatible types in comparison expression (different address spaces)
> net/tipc/name_table.c:977:17: error: incompatible types in comparison expression (different address spaces)
> 
> To silence these spare complaints, an RCU annotation should be added to
> "next" pointer of hlist_node structure through hlist_next_rcu() macro
> when iterating over a hlist with hlist_for_each_entry_from_rcu().
> 
> Signed-off-by: Ying Xue <ying.xue@...driver.com>

Queued for testing, thank you!

If testing goes well, I will push it into the 4.3 merge window.

							Thanx, Paul

> ---
> Changes:
>  - Replace rcu_dereference_bh() with rcu_dereference_raw() suggested
>    by Paul.
> 
>  include/linux/rculist.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/rculist.h b/include/linux/rculist.h
> index a18b16f..fd1c870 100644
> --- a/include/linux/rculist.h
> +++ b/include/linux/rculist.h
> @@ -549,8 +549,8 @@ static inline void hlist_add_behind_rcu(struct hlist_node *n,
>   */
>  #define hlist_for_each_entry_from_rcu(pos, member)			\
>  	for (; pos;							\
> -	     pos = hlist_entry_safe(rcu_dereference((pos)->member.next),\
> -			typeof(*(pos)), member))
> +	     pos = hlist_entry_safe(rcu_dereference_raw(hlist_next_rcu(	\
> +			&(pos)->member)), typeof(*(pos)), member))
> 
>  #endif	/* __KERNEL__ */
>  #endif
> -- 
> 1.7.9.5
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/