linux-kernel - Re: [PATCH] perf build: Suppress warning about missing libbabeltrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150327111855.GB8749@gmail.com>
Date:	Fri, 27 Mar 2015 12:18:55 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Jiri Olsa <jolsa@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jeremie Galarneau <jgalar@...icios.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Tom Zanussi <tzanussi@...il.com>,
	Wang Nan <wangnan0@...wei.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf build: Suppress warning about missing libbabeltrace


* Jiri Olsa <jolsa@...nel.org> wrote:

> Be silent about missing babeltrace library until the needed
> version (1.3) is pushed into most common distros.
> 
> Requested-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> Link: http://lkml.kernel.org/n/tip-95mcd8hoxyt43jighilggjej@git.kernel.org
> ---
>  tools/perf/config/Makefile | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index cd121dfc4de9..2d9142b10cd3 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -606,7 +606,12 @@ ifndef NO_LIBBABELTRACE
>      EXTLIBS += -lbabeltrace-ctf
>      $(call detected,CONFIG_LIBBABELTRACE)
>    else
> -    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
> +#
> +# Be silent about missing babeltrace library
> +# until the needed version (1.3) is pushed
> +# into most common distros.
> +#
> +#    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
>      NO_LIBBABELTRACE := 1
>    endif
>  endif

But, but ... the feature detection is still executed, and it slows 
down the regular build on 99.9999% of the systems, right?

I don't mind carrying the code, but could we make it such that it 
needs some special option to build or so?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/