linux-kernel - [PATCH 0/5] dmaengine: Fix memory leak amongs virt-dma users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Mar 2015 13:35:50 +0200
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	<vinod.koul@...el.com>, <linux@....linux.org.uk>
CC:	<dan.j.williams@...el.com>, <dmaengine@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: [PATCH 0/5] dmaengine: Fix memory leak amongs virt-dma users

Hi,

Due to the implementation of some of the drivers using virt-dma they leak memory
by design.
All it takes is to stop a transfer which is not yet completed, this includes
cyclic (audio) channels also.
These drivers tend to remove the vdesc->node from the virt-dma lists when they
start the transfer. In terminate all vchan_get_all_descriptors() will not find
the transfer which is still running (not in any of the lists) so the free_desc
callback will not be called on them leaving us with memory leak.

There are other drivers leaking memory IMHO, but I was not sure how to fix them:
sun6i-dma,
sa11x0-dma,
k3dma

Others are already doing something to prevent the leak by either directly
freeing the desc or by adding back the vdesc->node to a list.

Regards,
Peter
---
Peter Ujfalusi (4):
  dmaengine: omap-dma: Fix memory leak when terminating running transfer
  dmaengine: bcm2835-dma: Fix memory leak when stopping a running
    transfer
  dmaengine: hsu: Fix memory leak when stopping a running transfer
  dmaengine: moxart-dma: Fix memory leak when stopping a running
    transfer

Petr Kulhavy (1):
  dmaengine: edma: fix memory leak when terminating running transfers

 drivers/dma/bcm2835-dma.c | 1 +
 drivers/dma/edma.c        | 7 +++++++
 drivers/dma/hsu/hsu.c     | 5 ++++-
 drivers/dma/moxart-dma.c  | 4 +++-
 drivers/dma/omap-dma.c    | 1 +
 5 files changed, 16 insertions(+), 2 deletions(-)

-- 
2.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/