linux-kernel - Re: [PATCH] eeprom: at24: Add support for large EEPROMs connected to SMBus adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5515523F.9010609@roeck-us.net>
Date:	Fri, 27 Mar 2015 05:51:11 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Wolfram Sang <wsa@...-dreams.de>
CC:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eeprom: at24: Add support for large EEPROMs connected
 to SMBus adapters

On 03/27/2015 01:09 AM, Wolfram Sang wrote:
>
>> just to give you an update: I do have some code, but it is a bit messy,
>> and it doesn't work well for ds2482 (the chip behind it still hangs up
>> if I access it in parallel through i2c-dev). On top of that, it causes
>> pretty significant slow-downs when accessing other devices on the same
>> bus at the same time. Not surprising, I guess, since it expands the scope
>> of the bus lock significantly.
>
> Just to get a better idea: Did you try taking the adapter_lock before
> the two SMBus command which needed to be concatenated (and use
> smbus_xfer directly)?
>
I did. I didn't use smbus_xfer directly, though, but introduced lockless
versions of the various smbus commands, and kept using those.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/