[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <37D7C6CF3E00A74B8858931C1DB2F0770177AA4A@SHSMSX103.ccr.corp.intel.com>
Date: Fri, 27 Mar 2015 13:09:53 +0000
From: "Liang, Kan" <kan.liang@...el.com>
To: Peter Zijlstra <peterz@...radead.org>
CC: "eranian@...gle.com" <eranian@...gle.com>,
"andi@...stfloor.org" <andi@...stfloor.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1] perf/x86: filter branches for PEBS event
> On Thu, Mar 26, 2015 at 02:13:23PM -0400, kan.liang@...el.com wrote:
> > This patch move intel_shared_regs_constraints for branch_reg ahead of
> > intel_pebs_constraints.
>
> Why not all shared regs?
Yes, all shared regs can also be moved ahead.
The patch is named for modifying the branch filter. I didn't want to change
other codes. So I keep them unchanged.
I will do it in next version.
>
> > intel_shared_regs_constraints for branch_reg doesn't modify event->hw,
> > so it's safe to be called before intel_pebs_constraints.
> > intel_shared_regs_constraints for branch_reg also special case when it
> > returns &emptyconstraint. It put constraints for extra_reg. This patch
> > remove it. Because it will never get constraints for extra_reg if
> > return is &emptyconstraint.
>
> -ENOPARSE.
Will remove the description, since it doesn't need in next version.
Thanks,
Kan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists