linux-kernel - Re: [PATCH] drm/i915: fix simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150327134911.GU23521@phenom.ffwll.local>
Date:	Fri, 27 Mar 2015 14:49:11 +0100
From:	Daniel Vetter <daniel@...ll.ch>
To:	kbuild test robot <fengguang.wu@...el.com>
Cc:	Michel Thierry <michel.thierry@...el.com>, kbuild-all@...org,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Ben Widawsky <ben@...dawsk.net>,
	Jani Nikula <jani.nikula@...ux.intel.com>,
	David Airlie <airlied@...ux.ie>,
	intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915: fix simple_return.cocci warnings

On Fri, Mar 27, 2015 at 07:26:35PM +0800, kbuild test robot wrote:
> drivers/gpu/drm/i915/i915_gem_gtt.c:1349:1-4: WARNING: end returns can be simpified and declaration on line 1347 can be dropped
> 
>  Simplify a trivial if-return sequence.  Possibly combine with a
>  preceding function call.
> Generated by: scripts/coccinelle/misc/simple_return.cocci
> 
> CC: Michel Thierry <michel.thierry@...el.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

Queued for -next, thanks for the patch.
-Daniel

> ---
> 
>  i915_gem_gtt.c |    8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -1344,13 +1344,7 @@ err_out:
>  
>  static int gen6_ppgtt_alloc(struct i915_hw_ppgtt *ppgtt)
>  {
> -	int ret;
> -
> -	ret = gen6_ppgtt_allocate_page_directories(ppgtt);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return gen6_ppgtt_allocate_page_directories(ppgtt);
>  }
>  
>  static void gen6_scratch_va_range(struct i915_hw_ppgtt *ppgtt,

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/