linux-kernel - Re: [PATCH] i2c: davinci: fixup wait_for_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Mar 2015 16:50:34 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	Sekhar Nori <nsekhar@...com>,
	Kevin Hilman <khilman@...prootsystems.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: davinci: fixup wait_for_completion_timeout handling

On Tue, Mar 17, 2015 at 03:51:13AM -0400, Nicholas Mc Guire wrote:
> wait_for_completion_timeout return 0 (timeout) or >=1 (completion) so the check
> for >= 0 is always true and can be dropped implying that r==-EREMOTEIO and thus
> the return of -EREMOTEIO can be done in the   if (dev->buf_len)  branch.
> As wait_for_completion_timeout returns unsigned long not int, and   int r   is
> exclusively used for wait_for_completion_timeout it is renamed and the type
> changed to unsigned long.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)