linux-kernel - Re: [PATCH] mtd:spi-nor: Add lock and unlock callback functions to struct spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150327174042.GZ32500@ld-irv-0074>
Date:	Fri, 27 Mar 2015 10:40:42 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Viet Nga Dao <vndao@...era.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	nga_chi86 <ngachi86@...il.com>
Subject: Re: [PATCH] mtd:spi-nor: Add lock and unlock callback functions to
 struct spi_nor

On Fri, Mar 20, 2015 at 09:15:48AM +0800, Viet Nga Dao wrote:
> On Fri, Mar 20, 2015 at 1:49 AM, Brian Norris <computersforpeace@...il.com> wrote:
> > On Mon, Mar 16, 2015 at 01:15:14AM -0700, vndao@...era.com wrote:
> >> From: VIET NGA DAO <vndao@...era.com>
> >>
> >> This patch introduces a properly-replaceable spi_nor callback that does
> >> flash specific lock and unlock. The existing code for spi_nor_lock and
> >> spi_nor_unlock is moved into their own functions which are stm_lock and
> >> stm_unlock.
> >
> > I'm curious; is this a complete ripoff of my code [1]? You haven't
> > credited my authorship at all. That's a big no-no. Typically you keep
> > the 'From:' and Signed-off-by of the original author if you're going to
> > modify/redistribute it. (Admittedly, I didn't provide the S-o-b on my
> > informal patch.)
> >
> > Anyway, that's all fine this time, but please avoid doing this in the
> > future; I can fix up the authorship, etc., and apply it, if it gets an
> > Ack/Tested-by from one or more reviewers (e.g., you). BTW, I hope you at
> > least tested this, right?
> 
> Hi Brian,
> I am so sorry for this mistake. it is not my intention. :(  I am new
> to kernel driver and up-streaming thing, that is why i do not know the
> proper way. Yes, please change the authorship to you.
> Yes, i tested it.

OK, no worries. Applied my own version (only differed by whitespace) and
added your Tested-by.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/