linux-kernel - Re: [PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150327202446.GB4027@n2100.arm.linux.org.uk>
Date:	Fri, 27 Mar 2015 20:24:46 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	vinod.koul@...el.com, tony@...mide.com, grant.likely@...aro.org,
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org, nm@...com
Subject: Re: [PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from
 DT if it is available

On Fri, Mar 27, 2015 at 02:26:51PM +0200, Peter Ujfalusi wrote:
> +	if (!pdev->dev.of_node || of_property_read_u32(pdev->dev.of_node,
> +						       "dma-requests",
> +						       &od->dma_requests)) {
> +		dev_info(&pdev->dev,
> +			 "Missing dma-requests property, using %u.\n",
> +			 OMAP_SDMA_REQUESTS);
> +		od->dma_requests = OMAP_SDMA_REQUESTS;
> +	}

Are all OMAPs including OMAP1 being converted to DT?  If not, don't
introduce noisy printks for which a platform can't do anything about.
Think about this please - if there's no of_node, then why complain
about a missing OF property?

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/