linux-kernel - Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <201503272154.04582@pali>
Date:	Fri, 27 Mar 2015 21:54:04 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Santiago Gala <sgala@...che.org>
Cc:	Hans de Goede <hdegoede@...hat.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

On Friday 27 March 2015 21:32:12 Santiago Gala wrote:
> I guess the difference is more due to new limits reported.
> 
> Now I get only one device:
> 
> /dev/input/event11
>    bustype : BUS_I8042
>    vendor  : 0x2
>    product : 0x8
>    version : 1792
>    name    : "AlpsPS/2 ALPS GlidePoint"
>    phys    : "isa0060/serio1/input0"
>    bits ev : EV_SYN EV_KEY EV_ABS
> 

Ok, it means that trackstick detection patch detected that you do 
not have trackstick (and you have only touchpad device).

And also that psmouse.ko is really using ALPS driver.

> And it produces different output in evemu-describe. I attach
> alps11-new.txt (the new one). See fragment of difference with
> relevant previous one:
> 
> @@ -38,17 +38,17 @@
>  #     Event code 53 (ABS_MT_POSITION_X)
>  #       Value      0
>  #       Min        0
> -#       Max      448
> +#       Max     4095
>  #       Fuzz       0
>  #       Flat       0
> -#       Resolution 4
> +#       Resolution 42
>  #     Event code 54 (ABS_MT_POSITION_Y)
>  #       Value      0
>  #       Min        0
> -#       Max        0
> +#       Max     2047
>  #       Fuzz       0
>  #       Flat       0
> -#       Resolution 0
> +#       Resolution 38
>  #     Event code 57 (ABS_MT_TRACKING_ID)
>  #       Value      0
>  #       Min        0
> 
> So resolutions are reported clearly different than with the
> broken patch.
> 

Can you look at difference between old 3.19 kernel version and 
this new one? To check if there is no regression.

> Regards
> Santiago
> 
> El vie., 27 de marzo de 2015 a las 21:09, Pali Rohár
> (<pali.rohar@...il.com>)
> 
> escribió:
> > Hello,
> > 
> > there should no functional changes (e.g. acceleration speed,
> > etc.). And if yes, there is probably some side effect which
> > should be investigated.
> > 
> > Please can you provide output from dmesg (grep for psmouse
> > or input) and also output from lsinput?
> > 
> > That changed acceleration/speed sounds like psmouse
> > fallbacks to some ImPS/2 relative protocol and not ALPS...
> > 
> > On Friday 27 March 2015 20:46:59 Santiago Gala wrote:
> > > It works quite well! :)
> > > 
> > > I got some issues: at first it didn't work after I mv'ed
> > > the original and put the unzipped new in its place. After
> > > reboot it failed exactly the same, but after I "sudo
> > > /etc/init.d/lightdm stop; sudo modprobe -r psmouse; sudo
> > > modprobe psmouse; sudo /etc/init.d/lightdm start" it
> > > worked. Then I remembered about the initrd.img which
> > > should contain it. So I did "sudo dpkg-reconfigure
> > > linux-image-4.0.0-040000rc5-generic", rebooted again and
> > > here I am.
> > > 
> > > 
> > > Things seem to work all right. The only thing I notice is
> > > that the old driver moved fast in console mode (with gpm)
> > > while the new one is rather slow, would need to tweak the
> > > acceleration configuration. even after adding
> > > "responsiveness=15" to the configuration, as the sample
> > > /etc/gpm.conf says, it is slower than the previous kernel
> > > with the stock configuration.
> > > 
> > > 
> > > Regards
> > > 
> > > Santiago
> > > 
> > > 
> > > El vie., 27 de marzo de 2015 a las 18:17, Pali Rohár
> > > (<pali.rohar@...il.com>) escribió:
> > > 
> > > On Thursday 26 March 2015 16:33:13 you wrote:
> > > > El mar., 24 de marzo de 2015 a las 17:48, Pali Rohár
> > > > (<pali.rohar@...il.com>)
> > > > 
> > > > escribió:
> > > > > Hello, I can compile psmouse.ko module for you. Just
> > > > > let me know which ubuntu kernel (and from) are you
> > > > > using.
> > > > 
> > > > This one could do:
> > > > 
> > > > http://kernel.ubuntu.com/~kernel-ppa/mainline/v4.0-rc5-v
> > > > ivid /
> > > > 
> > > > or at a choice any further one (they get published as
> > > > they are released)
> > > > 
> > > > Regards
> > > > Santiago
> > > 
> > > Hello, in attachment is gzipped psmouse.ko module compiled
> > > against above ubuntu kernel from linus git tree (3c435c1e)
> > > with additional patches:
> > > 
> > > https://lkml.org/lkml/2015/3/21/282
> > > https://lkml.org/lkml/2015/3/22/93
> > > https://lkml.org/lkml/2015/3/22/94
> > > 
> > > Test it and if everything works as expected, please send
> > > email to all all people and ML. Thanks.
> > > 
> > > --
> > > Pali Rohár
> > > pali.rohar@...il.com
> > 
> > --
> > Pali Rohár
> > pali.rohar@...il.com

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)