linux-kernel - Re: [PATCH 1/3] perf/e6500: Make event translations available in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Mar 2015 16:34:24 -0500
From:	Kim Phillips <kim.phillips@...escale.com>
To:	Tom Huynh <tommy.xhuynh@...il.com>
CC:	Andi Kleen <andi@...stfloor.org>, Ingo Molnar <mingo@...nel.org>,
	"Jiri Olsa" <jolsa@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Tom Huynh <tom.huynh@...escale.com>,
	<benh@...nel.crashing.org>, <paulus@...ba.org>,
	<mpe@...erman.id.au>, <mingo@...hat.com>, <acme@...nel.org>,
	<Kim.Phillips@...escale.com>, <linuxppc-dev@...ts.ozlabs.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] perf/e6500: Make event translations available in
 sysfs

crickets.

How do we make progress in this area?

(a) can we assume Andi's json format is acceptable?  We would like
to know this so we don't have to reformat our data more than once.

(b) Would an acceptable interim resolution the 'download area'
problem be to take Andi's "perf: Add support for full Intel event
lists v8" and change the 'download' to refer to
tools/perf/event-tables/?

(c) If not, given we don't know how to get us out of the current
status quo, can this patchseries still be applied, given the
original complaint was the size of our events-list.h (whereas
power7-events-list.h is almost twice the size)?  If not, patch 3/3
in this series is still valid, no matter what, and it should still
be applied (let us know if we need to resubmit).

Thanks,

Kim


On Mon, 16 Feb 2015 10:10:45 -0600
Tom Huynh <tommy.xhuynh@...il.com> wrote:

> On Mon, Feb 09, 2015 at 09:40:19PM +0100, Andi Kleen wrote:
> > > I'll NAK any external 'download area' (and I told that Andi 
> > > before): tools/perf/event-tables/ or so is a good enough 
> > > 'download area' with fast enough update cycles.
> > 
> > The proposal was to put it on kernel.org, similar to how
> > external firmware blobs are distributed. CPU event lists
> > are data sheets, so are like firmware. They do not
> > follow the normal kernel code licenses. They are not 
> > source code. They cannot be reviewed in the normal way.
>  
> Could you provide more details about the license and review 
> concern? How are the event list files different from hardware-
> specific information (e.g. reg mapping) in header files?
> 
> > > If any 'update' of event descriptions is needed it can 
> > > happen through the distro package mechanism, or via a 
> > > simple 'git pull' if it's compiled directly.
> > > 
> > > Lets not overengineer this with any dependence on an 
> > > external site and with a separate update mechanism - lets 
> > > just get the tables into tools/ and see it from there...
> > 
> > That experiment has been already done for oprofile,
> > didn't work very well.
> 
> Please excuse my ignorance, could you say exactly what didn't
> work well for oprofile?
> 
> Ingo's suggestion seems good to me because these event files 
> will be transparent to the users, and it's just more 
> convenient not having to go to a website to look for 
> the event file that matches the machine to download.
> The distro package or the perf make mechanism can put these
> files into the appropriate directory. The users who are not
> perf developers won't need to know about these files.
> 
> - Tom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/