linux-kernel - Re: [PATCH] fs: show locked and lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Mar 2015 22:42:37 +0100
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	Andrey Vagin <avagin@...nvz.org>
Cc:	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Pavel Emelyanov <xemul@...allels.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] fs: show locked and lock_ro options in mountinfo

On Fri, Mar 27, 2015 at 9:39 PM, Andrey Vagin <avagin@...nvz.org> wrote:
> I don't see any reasons to hide them. This information can help to
> understand errors.

Because these flags are set/read only internally by the VFS. In contrast
to the other flags shown by mountinfo MNT_LOCKED is not a mount option.

Why does it help to debug errors?
How would a user know that mount() with MS_BIND returns EINVAL because
the mount source is MNT_LOCKED? This information is useless for her.
If you argue like that you'd have to expose the whole VFS state to userland.

> And this information is required for correct checkpoint/restore of mount
> namespaces.

Why especially MNT_LOCKED and not all the other flags used by VFS?
Say MNT_DOOMED?

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/