linux-kernel - Re: [PATCH 2/3] toshiba_acpi: Fix typos in pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Mar 2015 19:58:55 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Azael Avalos <coproscefalo@...il.com>
Cc:	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] toshiba_acpi: Fix typos in pr_* messages from USB
 Fleep Functions

On Fri, Mar 27, 2015 at 03:09:25PM -0600, Azael Avalos wrote:
> This patch fixes typos in the pr_* messages from the USB Sleep
> Functions.
> 
> Signed-off-by: Azael Avalos <coproscefalo@...il.com>
> ---
>  drivers/platform/x86/toshiba_acpi.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
> index 595f12c..3bb456c 100644
> --- a/drivers/platform/x86/toshiba_acpi.c
> +++ b/drivers/platform/x86/toshiba_acpi.c
> @@ -955,11 +955,11 @@ static int toshiba_usb_rapid_charge_get(struct toshiba_acpi_dev *dev,
>  	status = tci_raw(dev, in, out);
>  	sci_close(dev);
>  	if (ACPI_FAILURE(status) || out[0] == TOS_FAILURE) {
> -		pr_err("ACPI call to get USB S&C battery level failed\n");
> +		pr_err("ACPI call to get USB Rapid Charge failed\n");
>  		return -EIO;
>  	} else if (out[0] == TOS_NOT_SUPPORTED ||
>  		   out[0] == TOS_INPUT_DATA_ERROR) {
> -		pr_info("USB Sleep and Charge not supported\n");
> +		pr_info("USB Rapid Charge not supported\n");

This is a name change, not a typo fix. You added a comment in 1/3 using Sleep
and Charge, should this patch perhaps come first?

Or... hrm... this is using the correct name for each state, and 1/3 added Sleep
and Charge to the correct one... right, probably just need a better commit
message. Not a type, but fixing the messages reporting the wrong states.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/