linux-kernel - Re: d63e2e1f3df breaks sparc/T5-8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150328081843.GA27114@ravnborg.org>
Date:	Sat, 28 Mar 2015 09:18:43 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	David Ahern <david.ahern@...cle.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"sparclinux@...r.kernel.org" <sparclinux@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: d63e2e1f3df breaks sparc/T5-8

> >>  config ARM_THUMB
> >>       bool "Support Thumb user binaries" if !CPU_THUMBONLY
> >>       depends on CPU_ARM720T || CPU_ARM740T || CPU_ARM920T || CPU_ARM922T || \
> >> Index: linux-2.6/arch/arm64/Kconfig
> >> ===================================================================
> >> --- linux-2.6.orig/arch/arm64/Kconfig
> >> +++ linux-2.6/arch/arm64/Kconfig
> >> @@ -125,6 +125,9 @@ config HAVE_GENERIC_RCU_GUP
> >>  config ARCH_DMA_ADDR_T_64BIT
> >>       def_bool y
> >>
> >> +config ARCH_PCI_BUS_ADDR_T_64BIT
> >> +     def_bool y
> >> +
> > Use select
> ...
> 
> I was trying to keep the style to be consistent with old one in each Kconfig.
> 
> So do we just need to make sure new added lines to use new style?

Use new style select everywhere.
That could maybe in the future trigger someone to update the different arch
configs to use select for the remaining bits.

> >> Index: linux-2.6/include/linux/types.h
> >> ===================================================================
> >> --- linux-2.6.orig/include/linux/types.h
> >> +++ linux-2.6/include/linux/types.h
> >> @@ -146,6 +146,13 @@ typedef u64 dma_addr_t;
> >>  typedef u32 dma_addr_t;
> >>  #endif /* dma_addr_t */
> >>
> >> +/* A pci_bus_addr_t can hold pci bus address for the platform */
> >> +#ifdef CONFIG_ARCH_PCI_BUS_ADDR_T_64BIT
> >> +typedef u64 pci_bus_addr_t;
> >> +#else
> >> +typedef u32 pci_bus_addr_t;
> >> +#endif /* pci_bus_addr_t */
> >> +
> > Looking att all the Kconfig logic I get the impression that
> > the type of pci_bus_addr_t equals unsigned long.
> > If this is correct then you can skip that and things
> > gets much simpler.
> 
> For x86 32bit with PAE support, we could use 64bit for bus address.
> but unsigned long is 32bit.

Missed that part - OK.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/