linux-kernel - Re: [PATCH] tools: iio: Add help option for generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55168C7C.9060704@kernel.org>
Date:	Sat, 28 Mar 2015 11:11:56 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Alin Arhip <alin.g.arhip@...el.com>
CC:	knaack.h@....de, lars@...afoo.de, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools: iio: Add help option for generic_buffer

On 27/03/15 12:42, Alin Arhip wrote:
> From: Alin Gabriel Arhip <alin.g.arhip@...el.com>
> 
> This patch adds usage instructions and -h parameter to view available
> command line parameters.
> 
> Signed-off-by: Alin Gabriel Arhip <alin.g.arhip@...el.com>
Good in principal, but I wonder if we can't make it more informative.
Some of the help is talking more about internals of the code rather
than what the option means to the user!
> ---
>  tools/iio/generic_buffer.c | 22 ++++++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/iio/generic_buffer.c b/tools/iio/generic_buffer.c
> index 8f8f058..8dd77ac 100644
> --- a/tools/iio/generic_buffer.c
> +++ b/tools/iio/generic_buffer.c
> @@ -166,7 +166,17 @@ int main(int argc, char **argv)
>  
>  	struct iio_channel_info *channels;
>  
> -	while ((c = getopt(argc, argv, "l:w:c:et:n:g")) != -1) {
> +	if (argc <= 1) {
> +		printf("Usage: %s -n <device_name> -t <trigger_name>\n"
> +			"\tIf trigger name is not specified the program\n"
> +			"\tassumes you want a dataready trigger associated\n"
> +			"\twith the device and goes looking for it.\n"
> +			"\tUse -h to see available command line parameters.\n",
> +			argv[0]);
> +		return -1;
> +	}
> +
> +	while ((c = getopt(argc, argv, "l:w:c:et:n:gh")) != -1) {
>  		switch (c) {
>  		case 'n':
>  			device_name = optarg;
> @@ -190,7 +200,15 @@ int main(int argc, char **argv)
>  		case 'g':
>  			notrigger = 1;
>  			break;
> -		case '?':
> +		case '?': case 'h':
> +			printf("Usage: %s -n <device_name> to set device name\n"
> +				"\t-t <trigger_name> to set trigger name\n"
> +				"\t-e to set noevents to 1\n"
This option was to allow reads of more than one sample (as that's what
poll used to support).  With the new poll support for watersheds
(in the software buffer) we probably want to drop this option entirely and
support those instead.


> +				"\t-c <num_loops> to set number of loops\n"
loops of what? Again, the meaning of this will change with support for
watershed based poll.
> +				"\t-w <timedelay> to set time delay\n"
to set time delay between attempts to read from the buffer.
> +				"\t-l <buf_len> to set buffer length\n"
> +				"\t-g to set notrigger to 1\n"
Make it explicit that some devices do not have a trigger as they push
the data directly to the buffer (typically hardware buffer equipped devices).
> +				"\t-h to see this help\n", argv[0]);
>  			return -1;
>  		}
>  	}
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/