linux-kernel - Re: [PATCH 36/86] edac/x38_edac: use uapi/linux/pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150329162622-mutt-send-email-mst@redhat.com>
Date:	Sun, 29 Mar 2015 16:27:17 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	linux-kernel@...r.kernel.org,
	Doug Thompson <dougthompson@...ssion.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	linux-edac@...r.kernel.org
Subject: Re: [PATCH 36/86] edac/x38_edac: use uapi/linux/pci_ids.h directly

On Sun, Mar 29, 2015 at 03:59:23PM +0200, Borislav Petkov wrote:
> On Sun, Mar 29, 2015 at 03:40:32PM +0200, Michael S. Tsirkin wrote:
> > Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h,
> > use the new header directly so we can drop
> > the wrapper in include/linux/pci_ids.h.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> > ---
> >  drivers/edac/x38_edac.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c
> > index 7c5cdc6..9ce8dd1 100644
> > --- a/drivers/edac/x38_edac.c
> > +++ b/drivers/edac/x38_edac.c
> > @@ -12,7 +12,7 @@
> >  #include <linux/module.h>
> >  #include <linux/init.h>
> >  #include <linux/pci.h>
> > -#include <linux/pci_ids.h>
> > +#include <uapi/linux/pci_ids.h>
> >  #include <linux/edac.h>
> 
> Can you please merge all edac patches into one?
> 
> Provided people are fine with exporting the PCI defines to userspace, of
> course. I personally can't think of a reason why not - those are static
> PCI device numbers and they're in hardware anyway.

OK. I saw they have diff separate entries in maintainers so I wasn't
sure it's a good idea, splitting up patches is always a safe thing to
do.

> -- 
> Regards/Gruss,
>     Boris.
> 
> ECO tip #101: Trim your mails when you reply.
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/