linux-kernel - Re: [PATCH 40/86] ide/generic: use uapi/linux/pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150329164934-mutt-send-email-mst@redhat.com>
Date:	Sun, 29 Mar 2015 16:52:26 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>, linux-ide@...r.kernel.org
Subject: Re: [PATCH 40/86] ide/generic: use uapi/linux/pci_ids.h directly

On Sun, Mar 29, 2015 at 05:12:45PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 3/29/2015 4:40 PM, Michael S. Tsirkin wrote:
> 
> >Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h,
> >use the new header directly so we can drop
> >the wrapper in include/linux/pci_ids.h.
> 
> >Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> >---
> >  drivers/ide/ide-generic.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> >diff --git a/drivers/ide/ide-generic.c b/drivers/ide/ide-generic.c
> >index 54d7c46..4edb39f 100644
> >--- a/drivers/ide/ide-generic.c
> >+++ b/drivers/ide/ide-generic.c
> >@@ -11,7 +11,7 @@
> >  #include <linux/init.h>
> >  #include <linux/module.h>
> >  #include <linux/ide.h>
> >-#include <linux/pci_ids.h>
> >+#include <uapi/linux/pci_ids.h>
> 
>    Hm, I thought include/uapi/ was always in #include file search path, so
> there should be no need to explicitly mention it, and so no need for this
> patch...
> 
> WBR, Sergei

There's some confusion about whether headers should be preferably
included using #include <uapi/linux/...> or #include <linux/...>.
It might be a good idea to document this somewhere.

-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/