lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 28 Mar 2015 17:26:34 -0700 From: Shirish Gajera <gshirishfree@...il.com> To: Richard Weinberger <richard@....at> Cc: Joe Perches <joe@...ches.com>, w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca, samuel.thibault@...-lyon.org, gregkh@...uxfoundation.org, domagoj.trsan@...il.com, mahfouz.saif.elyazal@...il.com, ben@...adent.org.uk, roxanagabriela10@...il.com, sulamiification@...il.com, dilekuzulmez@...il.com, daeseok.youn@...il.com, aysemelikeyurtoglu@...il.com, rusty@...tcorp.com.au, tapaswenipathak@...il.com, vthakkar1994@...il.com, speakup@...ux-speakup.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: speakup: Fix warning of line over 80 characters. On Sun, Mar 29, 2015 at 12:54:45AM +0100, Richard Weinberger wrote: > Am 29.03.2015 um 00:44 schrieb Shirish Gajera: > > On Sat, Mar 28, 2015 at 02:35:19PM -0700, Joe Perches wrote: > >> On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote: > >>> Am 28.03.2015 um 22:18 schrieb Joe Perches: > >>>> On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote: > >>>>> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera <gshirishfree@...il.com> wrote: > >>>>>> This patch fixes the checkpatch.pl warning: > >> [] > >>>>> Instead of blindly adding newlines to silence checkpatch.pl, what > >>>>> about reworking the code? > >>>>> printf("%s\n", ..) cries for a puts(). > >>>> > >>>> There is no synth_puts > >>> > >>> So what? > >>> Fix it! :-) > >> > >> Not sure that'd make the code better... ;-p > >> > >>> the whole code is horrible and lines other 80 chars are the *least* > >>> problem. > >> > >> Dunno about how horrible it is, my guess is it works. > >> > >>> Submitting a patch just for the sake of silencing checkpatch.pl is a waste of time. > >>> After applying this patch the driver 0 better than before. > >> > >> Agree with that. > >> > >> And truly, checkpatch is only a guide. > >> > >> Making the code better instead of merely style conforming > >> should be the primary goal of patches. > > > > This is my first patch. > > Are you sure? > http://lists.kernelnewbies.org/pipermail/kernelnewbies/2015-January/013187.html Yup, this patch never got merge because I was doing changes against wrong repo. > > > Actually on the website it's return that > > "Pick a warning, and try to fix it. For your first patch, only pick one > > warning. In the future you can group multiple changes into one patch, > > but only if you follow the PatchPhilosophy of breaking each patch into > > logical changes." > > > > My main aim is to get the patch in and get familier with the full system > > (code checking,flow etc.). So, I am fixing simple warning. > > > > If this code require changes then I can do as part of future changes. > > The future is now, please address these issues now. :-) > Again, blindly fixing checkpatch.pl warnings is worthless. > > Thanks, > //richard Are you sure you want me to do this changes. Because it will conflict the things written on http://kernelnewbies.org/ Thanks, Shirish -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists