linux-kernel - Re: [PATCH 62/86] staging/comedi: use uapi/linux/pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 29 Mar 2015 18:35:00 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	"Michael S. Tsirkin" <mst@...hat.com>, linux-kernel@...r.kernel.org
CC:	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH 62/86] staging/comedi: use uapi/linux/pci_ids.h directly

On 29/03/15 14:42, Michael S. Tsirkin wrote:
> Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h,
> use the new header directly so we can drop
> the wrapper in include/linux/pci_ids.h.
>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
>   drivers/staging/comedi/comedidev.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index e138eb0..1c3ac0b 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -556,7 +556,7 @@ void comedi_driver_unregister(struct comedi_driver *);
>   /* comedi_pci.c - comedi PCI driver specific functions */
>
>   /*
> - * PCI Vendor IDs not in <linux/pci_ids.h>
> + * PCI Vendor IDs not in <uapi/linux/pci_ids.h>
>    */
>   #define PCI_VENDOR_ID_KOLTER		0x1001
>   #define PCI_VENDOR_ID_ICP		0x104c
>

Hi Michael,

I don't understand why you need to change this and lots of other source 
code just to move a header into uapi when it hasn't been necessary for 
other headers that have been moved into uapi.  Surely kernel code can 
still use #include <linux/pci_ids.h> even though the header file is 
located at "include/uapi/linux/pci_ids.h"?

Also, this patch doesn't apply to the latest linux-next.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/