linux-kernel - Re: [RFC PATCH 08/11] lib: other kernel glue layer code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5518419E.8010007@nod.at>
Date:	Sun, 29 Mar 2015 20:17:02 +0200
From:	Richard Weinberger <richard@....at>
To:	Hajime Tazaki <tazaki@....wide.ad.jp>, linux-arch@...r.kernel.org
CC:	Arnd Bergmann <arnd@...db.de>, Jonathan Corbet <corbet@....net>,
	Jhristoph Lameter <cl@...ux.com>,
	Jekka Enberg <penberg@...nel.org>,
	Javid Rientjes <rientjes@...gle.com>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Jndrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	netdev@...r.kernel.org, linux-mm@...ck.org,
	Jeff Dike <jdike@...toit.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Mathieu Lacage <mathieu.lacage@...il.com>,
	Christoph Paasch <christoph.paasch@...il.com>
Subject: Re: [RFC PATCH 08/11] lib: other kernel glue layer code

Am 24.03.2015 um 14:10 schrieb Hajime Tazaki:
> These files are used to provide the same function calls so that other
> network stack code keeps untouched.
> 
> Signed-off-by: Hajime Tazaki <tazaki@....wide.ad.jp>
> Signed-off-by: Christoph Paasch <christoph.paasch@...il.com>
> ---
>  arch/lib/cred.c     |  16 +++
>  arch/lib/dcache.c   |  93 +++++++++++++++
>  arch/lib/filemap.c  |  27 +++++
>  arch/lib/fs.c       | 287 ++++++++++++++++++++++++++++++++++++++++++++
>  arch/lib/glue.c     | 336 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  arch/lib/inode.c    | 146 +++++++++++++++++++++++
>  arch/lib/modules.c  |  36 ++++++
>  arch/lib/pid.c      |  29 +++++
>  arch/lib/print.c    |  56 +++++++++
>  arch/lib/proc.c     | 164 +++++++++++++++++++++++++
>  arch/lib/random.c   |  53 +++++++++
>  arch/lib/security.c |  45 +++++++
>  arch/lib/seq.c      | 122 +++++++++++++++++++
>  arch/lib/splice.c   |  20 ++++
>  arch/lib/super.c    | 210 ++++++++++++++++++++++++++++++++
>  arch/lib/sysfs.c    |  83 +++++++++++++
>  arch/lib/vmscan.c   |  26 ++++
>  17 files changed, 1749 insertions(+)

BTW: Why do you need these stub implementations at all?
If I read your code correctly it is because you're linking against the whole net/ directory.
Let's take register_filesystem() again as example. net/socket.c references it in sock_init().
Maybe it would make sense to split socket.c into two files, net/socket.c and net/sockfs.c.
Such that you could link only net/socket.o.
Of course you'd have to convince networking folks first. :D

By linking selectively objects files from net/ you could get rid of a lot unneeded stubs.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/