linux-kernel - Re: [PATCH 10/11] staging: rtl8192e: Decrease nesting of rtllib_rx_auth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427670839.2715.44.camel@perches.com>
Date:	Sun, 29 Mar 2015 16:13:59 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/11] staging: rtl8192e: Decrease nesting of
 rtllib_rx_auth_resp()

On Mon, 2015-03-30 at 00:41 +0200, Mateusz Kulikowski wrote:
> Return from rtllib_rx_auth_resp() if auth_parse() fails.

Hello Mateusz.  Here are some trivial notes.

> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
[]
> +		/* Dummy wirless mode setting to avoid
> +		 * encryption issue */

Please use the typical networking comment style
(and correct the typo too)

		/* Dummy wireless mode setting to avoid
		 * encryption issue
		 */

> +		if (bSupportNmode) {
> +			ieee->SetWirelessMode(ieee->dev,
> +			   ieee->current_network.mode);
> +		} else {
> +			/*TODO*/
> +			ieee->SetWirelessMode(ieee->dev,
> +					      IEEE_G);

Many of these multiple line statements can be single line.

> +		}
> +
> +		if (ieee->current_network.mode ==
> +		    IEEE_N_24G && bHalfSupportNmode) {
> +			netdev_info(ieee->dev,
> +				    "======>enter half N mode\n");
> +			ieee->bHalfWirelessN24GMode =
> +						 true;
> +		} else
> +			ieee->bHalfWirelessN24GMode =
> +						 false;

Single line and better with braces.

> +
> +		rtllib_associate_step2(ieee);
> +	} else {
> +		rtllib_auth_challenge(ieee, challenge,
> +				      chlen);
>  	}
>  }

Single line.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/