linux-kernel - Re: [PATCH 10/11] staging: rtl8192e: Decrease nesting of rtllib_rx_auth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1427671736.2715.47.camel@perches.com>
Date:	Sun, 29 Mar 2015 16:28:56 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/11] staging: rtl8192e: Decrease nesting of
 rtllib_rx_auth_resp()

On Mon, 2015-03-30 at 01:21 +0200, Mateusz Kulikowski wrote:
> On 30.03.2015 01:13, Joe Perches wrote:
> > On Mon, 2015-03-30 at 00:41 +0200, Mateusz Kulikowski wrote:
> >> Return from rtllib_rx_auth_resp() if auth_parse() fails.
> >> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> > []
> >> +		/* Dummy wirless mode setting to avoid
> >> +		 * encryption issue */
> > 
> > Please use the typical networking comment style
> > (and correct the typo too)
> > 
> > 		/* Dummy wireless mode setting to avoid
> > 		 * encryption issue
> > 		 */
> 
> It was like that already - is it ok with you if I fix all the comments (in whole rtl8192e) in separate patch 
> (I can add it as #12 to v2) ?

Of course.

> > 
> >> +		if (bSupportNmode) {
> >> +			ieee->SetWirelessMode(ieee->dev,
> >> +			   ieee->current_network.mode);
> >> +		} else {
> >> +			/*TODO*/
> >> +			ieee->SetWirelessMode(ieee->dev,
> >> +					      IEEE_G);
> > 
> > Many of these multiple line statements can be single line.
> 
> I wanted to split change of logic and re-indentation;
> If you insist - I can merge patches #10 and #11 (#11 does what you ask for)

No worries, do what you think appropriate.
I think it's appropriate to fix one way or another.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/