linux-kernel - Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Mar 2015 09:45:08 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Marek Belisko <marek@...delico.com>
Cc:	johan@...nel.org, gregkh@...uxfoundation.org, corbet@....net,
	linux-usb@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, gta04-owner@...delico.com,
	"H. Nikolaus Schaller" <hns@...delico.com>
Subject: Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor
 and product id

On Sat, Mar 28, 2015 at 02:37:57PM +0100, Marek Belisko wrote:
> From: "H. Nikolaus Schaller" <hns@...delico.com>
> 
> While trying to test the Pyra GSM/GPS/3G module I had reconfigured
> the USB interface by mistake and therefore needed to run a different
> USB driver than CSC-ACM. It turned out that I need the "usbserial" driver.

CDC-ACM

> This file is an official description how to use it:
> Documentation/usb/usb-serial.txt
> 
> But it is outdated. The parameters vendor= and product= are no longer
> available since ca. 3.12 which means that documentation is lagging behind
> quite some time.

This is simply not true. The vendor and module parameters are still
there for usbserial (i.e. the generic driver).

Would you mind updating this patch to document the sysfs-method as an
alternative instead? Using sysfs is preferred as that functionality can
be used with any usb-serial driver and the drivers can also be compiled
in.

> Here was the solution:
> 
> https://bbs.archlinux.org/viewtopic.php?id=175499
> 
>   insmod usbserial vendor=0x#### product=0x####
> 
> becomes (first #### is vendor, second is product)
> 
>   modprobe usbserial
>   echo #### #### >/sys/bus/usb-serial/drivers/generic/new_id
> 
> This patch changes the documentation file as needed.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> Signed-off-by: Marek Belisko <marek@...delico.com>
> ---
>  Documentation/usb/usb-serial.txt | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/usb/usb-serial.txt b/Documentation/usb/usb-serial.txt
> index 947fa62..9f184d8 100644
> --- a/Documentation/usb/usb-serial.txt
> +++ b/Documentation/usb/usb-serial.txt
> @@ -466,11 +466,13 @@ Generic Serial driver
>    is required of your device is that it has at least one bulk in endpoint,
>    or one bulk out endpoint. 
>    
> -  To enable the generic driver to recognize your device, build the driver
> -  as a module and load it by the following invocation:
> -	insmod usbserial vendor=0x#### product=0x####
> -  where the #### is replaced with the hex representation of your device's
> -  vendor id and product id.
> +  To enable the generic driver to recognize your device, configure
> +  USB_SERIAL_GENERIC=y and build the driver as a module. Then load it by the

You don't need to build the driver as a module when using the sysfs
method.

> +  following invocation:
> +	modprobe usbserial
> +	echo #### #### >/sys/bus/usb-serial/drivers/generic/new_id
> +  where the the first #### is replaced with the hex representation of your
> +  device's vendor id and the second #### by the product id.
>  
>    This driver has been successfully used to connect to the NetChip USB
>    development board, providing a way to develop USB firmware without

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/