[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1427680141.2715.60.camel@perches.com>
Date: Sun, 29 Mar 2015 18:49:01 -0700
From: Joe Perches <joe@...ches.com>
To: Larry Finger <Larry.Finger@...inger.net>
Cc: David Miller <davem@...emloft.net>,
Stefano Brivio <stefano.brivio@...imi.it>,
Kalle Valo <kvalo@...eaurora.org>,
Brett Rudley <brudley@...adcom.com>,
Arend van Spriel <arend@...adcom.com>,
"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
Hante Meuleman <meuleman@...adcom.com>,
Johannes Berg <johannes.berg@...el.com>,
Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
Intel Linux Wireless <ilw@...ux.intel.com>,
linux-wireless@...r.kernel.org, b43-dev@...ts.infradead.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
brcm80211-dev-list <brcm80211-dev-list@...adcom.com>
Subject: Re: [PATCH net-next] wireless: Use bool function returns of
true/false instead of 1/0
On Sun, 2015-03-29 at 20:46 -0500, Larry Finger wrote:
> On 03/29/2015 08:29 PM, Joe Perches wrote:
> > Use bool constants as the return values instead of 1 and 0.
> >
> > Signed-off-by: Joe Perches <joe@...ches.com>
> > ---
> >> To be honest I'd might rather get bunches of these, there has to be a ton
> >> of them, than a slow trickle of one every few weeks/days.
> >
> > There aren't too many here either...
> >
> > drivers/net/wireless/b43/dma.c | 12 ++++++------
> > drivers/net/wireless/b43legacy/dma.c | 6 +++---
> > drivers/net/wireless/b43legacy/rfkill.c | 8 ++++----
> > drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c | 2 +-
> > drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c | 2 +-
> > drivers/net/wireless/iwlwifi/iwl-config.h | 4 ++--
> > 6 files changed, 17 insertions(+), 17 deletions(-)
>
> Please split these into separate patches for each driver. That way it will be
> possible to search 'git log' for the contributions to each driver. Otherwise,
> the patches are OK.
It's still possible.
git log <directory> shows the individual patches.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists