linux-kernel - Re: [PATCH v6 2/8] PM / devfreq: tegra: Update to v5 of the submitted patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <1040887254.91981427710975821.JavaMail.weblogic@epmlwas08a>
Date:	Mon, 30 Mar 2015 10:22:59 +0000 (GMT)
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Cc:	Mikko Perttunen <mikko.perttunen@...si.fi>,
	Alex Frid <afrid@...dia.com>,
	박경민 <kyungmin.park@...sung.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Alexandre Courbot <gnurou@...il.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 2/8] PM / devfreq: tegra: Update to v5 of the submitted
 patches

> Sender : Tomeu Vizoso<tomeu.vizoso@...labora.com>
> Date : 2015-03-17 18:36 (GMT+09:00)
> Title : [PATCH v6 2/8] PM / devfreq: tegra: Update to v5 of the submitted patches
> 
> There seemed to be some miscommunication and an old version of the
> submitted patches was merged.
> 
> This commit updates the driver to v5, which had this changelog:
> 
> * Clarify the units of avg_dependency_threshold
> * Remove unused references to platform_device
> * Enable and disable interrupts on governor events
> * Make sure we handle all interrupts for any of the devices we are sampling
> * Move locking to be per-actmon-device
> 
> Signed-off-by: Tomeu Vizoso 
> CC: Alex Frid 
> CC: Mikko Perttunen 
> ---
> drivers/devfreq/tegra-devfreq.c | 455 ++++++++++++++++++++++------------------
> 1 file changed, 252 insertions(+), 203 deletions(-)
> 
> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
> index 3479096..c71635a 100644
> --- a/drivers/devfreq/tegra-devfreq.c
> +++ b/drivers/devfreq/tegra-devfreq.c
[]
> -static struct devfreq_dev_profile tegra_devfreq_profile = {
> - .polling_ms = 0,
> - .target = tegra_devfreq_target,
> - .get_dev_status = tegra_devfreq_get_dev_status,
> -};
> +static int __init tegra_governor_init(void)
> +{
> + return devfreq_add_governor(&tegra_devfreq_governor);
> +}
> +subsys_initcall(tegra_governor_init);
> 
[]

It looks like you need to disable "module" in the corresponding Kconfig.

Do you want to add another patch to make it compilable as a module? or
do you want to make it "tristate" --> "bool"?

If you want the latter, I can do it for you before I send a pull request.

Please refer to the following:

mzx@...aku:/home/kernel.org/devfreq$ make ARCH=arm modules
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
make[1]: `include/generated/mach-types.h' is up to date.
  CALL    scripts/checksyscalls.sh
  CC [M]  drivers/devfreq/tegra-devfreq.o
drivers/devfreq/tegra-devfreq.c:758:1: error: redefinition of ‘__inittest’
drivers/devfreq/tegra-devfreq.c:613:1: note: previous definition of ‘__inittest’ was here
drivers/devfreq/tegra-devfreq.c:758:1: error: redefinition of ‘init_module’
drivers/devfreq/tegra-devfreq.c:613:1: note: previous definition of ‘init_module’ was here
make[2]: *** [drivers/devfreq/tegra-devfreq.o] Error 1
make[1]: *** [drivers/devfreq] Error 2
make: *** [drivers] Error 2
mzx@...aku:/home/kernel.org/devfreq$ 

Cheers,
MyungJoo