linux-kernel - Re: [PATCH v2 3/8] mmc: sdhci-st: Add delay management functions for top registers (eMMC).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150330103326.GB21893@griffinp-ThinkPad-X1-Carbon-2nd>
Date:	Mon, 30 Mar 2015 11:33:26 +0100
From:	Peter Griffin <peter.griffin@...aro.org>
To:	Maxime Coquelin <maxime.coquelin@...com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	patrice.chotard@...com, srinivas.kandagatla@...il.com,
	chris@...ntf.net, ulf.hansson@...aro.org, lee.jones@...aro.org,
	devicetree@...r.kernel.org, linux-mmc@...r.kernel.org,
	peppe.cavallaro@...com
Subject: Re: [PATCH v2 3/8] mmc: sdhci-st: Add delay management functions for
 top registers (eMMC).

Hi Maxime,

On Tue, 03 Mar 2015, Maxime Coquelin wrote:
> 
> On 02/26/2015 02:10 PM, Peter Griffin wrote:
> >Due to the tight timing constriants in some UHS modes, it is required to have
> s/constriant/constraints/

Will fix.

<snip>
> >+
> >+static inline void st_mmcss_set_static_delay(void __iomem *ioaddr)
> >+{
> >+	if (ioaddr) {
> Maybe you could do:
>     if (!ioaddr)
>         return;

Yes good idea, I have made that change in V3.
> 
>     writel_relaxed....
> >+		writel_relaxed(0x0, ioaddr + ST_TOP_MMC_DLY_CTRL);
> >+		writel_relaxed(ST_TOP_MMC_DLY_MAX,
> >+				ioaddr + ST_TOP_MMC_TX_CLK_DLY);
> >+	}
> >+}
> >+
> >+static inline void st_mmcss_set_dll(void __iomem *ioaddr)
> >+{
> >+	if (ioaddr) {
> Ditto

regards,

Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/