lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Mar 2015 09:39:49 -0400 From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> To: "Ouyang Zhaowei (Charles)" <ouyangzhaowei@...wei.com> Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>, David Vrabel <david.vrabel@...rix.com>, linux-kernel@...r.kernel.org, Dingweiping <weiping.ding@...wei.com>, Yanqiangjun <yanqiangjun@...wei.com>, Huanglinglong <huanglinglong@...wei.com> Subject: Re: [PATCH] xen: vcpu_info reinit error after hold/release if VM has multi-cpu On Mon, Mar 30, 2015 at 09:33:16PM +0800, Ouyang Zhaowei (Charles) wrote: > If the VM has multi-cpu the vcpu_info of cpu0 is the member of the structure HYPERVISOR_shared_info, > and the others is not, but after hold/release the VM, the vcpu_info will be reinitialized, What is 'hold/release' ? Pause and suspend? or do you mean suspend was cancelled? > the vcpu_info of all the vcpus will be considered as the member of HYPERVISOR_shared_info. > This will cause the cpu1 and other cpu keep receiving interrupts, and the cpu0 is waiting them to > finish the job. > So we do not reinit the vcpu_info if it's doing hold/release. s/"hold/release"/suspend cancelled/ ? > > Signed-off-by: Charles Ouyang <ouyangzhaowei@...wei.com> > --- > arch/x86/xen/suspend.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/xen/suspend.c b/arch/x86/xen/suspend.c > index c4df9db..832480c 100644 > --- a/arch/x86/xen/suspend.c > +++ b/arch/x86/xen/suspend.c > @@ -32,7 +32,8 @@ static void xen_hvm_post_suspend(int suspend_cancelled) > { > #ifdef CONFIG_XEN_PVHVM > int cpu; > - xen_hvm_init_shared_info(); > + if (!suspend_cancelled) > + xen_hvm_init_shared_info(); > xen_callback_vector(); > xen_unplug_emulated_devices(); > if (xen_feature(XENFEAT_hvm_safe_pvclock)) { > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists