linux-kernel - Re: [V7 PATCH 1/3] ACPICA: Add ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55195AE6.2050801@amd.com>
Date:	Mon, 30 Mar 2015 09:17:10 -0500
From:	Suravee Suthikulanit <suravee.suthikulpanit@....com>
To:	"Moore, Robert" <robert.moore@...el.com>,
	"rjw@...ysocki.net" <rjw@...ysocki.net>,
	"mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
	"Zheng, Lv" <lv.zheng@...el.com>,
	"hanjun.guo@...aro.org" <hanjun.guo@...aro.org>
CC:	"lenb@...nel.org" <lenb@...nel.org>,
	"hdegoede@...hat.com" <hdegoede@...hat.com>,
	"tj@...nel.org" <tj@...nel.org>,
	"mjg59@...f.ucam.org" <mjg59@...f.ucam.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"al.stone@...aro.org" <al.stone@...aro.org>,
	"graeme.gregory@...aro.org" <graeme.gregory@...aro.org>,
	"leo.duran@....com" <leo.duran@....com>,
	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linaro-acpi@...ts.linaro.org" <linaro-acpi@...ts.linaro.org>
Subject: Re: [V7 PATCH 1/3] ACPICA: Add ACPI _CLS processing

On 3/27/2015 12:51 PM, Moore, Robert wrote:
> +	cls_objects = obj_desc->package.elements;
> +
> +	if (obj_desc->common.type == ACPI_TYPE_PACKAGE &&
> +	    obj_desc->package.count == 3 &&
> +	    cls_objects[0]->common.type == ACPI_TYPE_INTEGER &&
> +	    cls_objects[1]->common.type == ACPI_TYPE_INTEGER &&
> +	    cls_objects[2]->common.type == ACPI_TYPE_INTEGER) {
> +
> +		/* Allocate a buffer for the CLS */
> +		cls = ACPI_ALLOCATE_ZEROED(sizeof(struct acpi_pnp_device_id) +
> +					 (acpi_size) 7);
>
> I would like to see an error returned if an object or subobject is of the incorrect type.
> Then, the caller knows not to attempt to look at it.
>

Ok. I will return AE_TYPE if the condition is false here.

Thanks,

Suravee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/