linux-kernel - Re: [PATCH] debugfs: allow bad parent pointers to be passed in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5519831B.8050500@linaro.org>
Date:	Mon, 30 Mar 2015 12:08:43 -0500
From:	Alex Elder <elder@...aro.org>
To:	Greg KH <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org
CC:	Viresh Kumar <viresh.kumar@...aro.org>
Subject: Re: [PATCH] debugfs: allow bad parent pointers to be passed in

On 03/30/2015 07:59 AM, Greg KH wrote:
> If something went wrong with creating a debugfs file/symlink/directory,
> that value could be passed down into debugfs again as a parent dentry.
> To make caller code simpler, just error out if this happens, and don't
> crash the kernel.
> 
> Reported-by: Alex Elder <elder@...aro.org>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Looks good.

Reviewed-by: Alex Elder <elder@...aro.org>

> 
> ---
>  fs/debugfs/inode.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -254,6 +254,9 @@ static struct dentry *start_creating(con
>  
>  	pr_debug("debugfs: creating file '%s'\n",name);
>  
> +	if (IS_ERR(parent))
> +		return parent;
> +
>  	error = simple_pin_fs(&debug_fs_type, &debugfs_mount,
>  			      &debugfs_mount_count);
>  	if (error)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/