linux-kernel - Re: [PATCH 5/7] ssb: Use bool function return values of true/false not 1/0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150330194901.5293fbe2@wiggum>
Date:	Mon, 30 Mar 2015 19:49:01 +0200
From:	Michael Büsch <m@...s.ch>
To:	Joe Perches <joe@...ches.com>, Kalle Valo <kvalo@...eaurora.org>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 5/7] ssb: Use bool function return values of true/false
 not 1/0

On Mon, 30 Mar 2015 10:43:21 -0700
Joe Perches <joe@...ches.com> wrote:

> Use the normal return values for bool functions
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/ssb/driver_gige.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ssb/driver_gige.c b/drivers/ssb/driver_gige.c
> index e973405..ebee6b0 100644
> --- a/drivers/ssb/driver_gige.c
> +++ b/drivers/ssb/driver_gige.c
> @@ -242,7 +242,7 @@ static int ssb_gige_probe(struct ssb_device *sdev,
>  bool pdev_is_ssb_gige_core(struct pci_dev *pdev)
>  {
>  	if (!pdev->resource[0].name)
> -		return 0;
> +		return false;
>  	return (strcmp(pdev->resource[0].name, SSB_GIGE_MEM_RES_NAME) == 0);
>  }
>  EXPORT_SYMBOL(pdev_is_ssb_gige_core);

Looks good.

Signed-off-by: Michael Buesch <m@...s.ch>

Kalle, can you take this one, please?

-- 
Michael

Content of type "application/pgp-signature" skipped