linux-kernel - Re: [PATCH 1/5] dmaengine: edma: fix memory leak when terminating running transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150330174827.GL7192@intel.com>
Date:	Mon, 30 Mar 2015 23:18:27 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	linux@....linux.org.uk, dan.j.williams@...el.com,
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Petr Kulhavy <petr@...ix.com>, stable@...r.kernel.org,
	linux-omap@...r.kernel.org
Subject: Re: [PATCH 1/5] dmaengine: edma: fix memory leak when terminating
 running transfers

On Fri, Mar 27, 2015 at 01:35:51PM +0200, Peter Ujfalusi wrote:
> From: Petr Kulhavy <petr@...ix.com>
> 
> If edma_terminate_all() was called while a transfer was running (i.e. after
> edma_execute() but before edma_callback()) the echan->edesc was not freed.
> 
> This was due to the fact that a running transfer is on none of the
> vchan lists: desc_submitted, desc_issued, desc_completed (edma_execute()
> removes it from the desc_issued list), so the vchan_dma_desc_free_list()
> called at the end of edma_terminate_all() didn't find it and didn't free it.
> 
> This bug was found on an AM1808 based hardware (very similar to da850evm,
> however using the second MMC/SD controller), where intense operations on the SD
> card wasted the device 128MB RAM within a couple of days.
> 
> Peter Ujfalusi:
> The issue is even more severe since it affects cyclic (audio) transfers as
> well. In this case starting/stopping audio will results memory leak.
> 
> Signed-off-by: Petr Kulhavy <petr@...ix.com>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> CC: <stable@...r.kernel.org>
> CC: <linux-omap@...r.kernel.org>
Applied, thanks

-- 
~Vinod

> ---
>  drivers/dma/edma.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index 741baa68365c..984c2b12dae3 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -268,6 +268,13 @@ static int edma_terminate_all(struct dma_chan *chan)
>  	 */
>  	if (echan->edesc) {
>  		int cyclic = echan->edesc->cyclic;
> +
> +		/*
> +		 * free the running request descriptor
> +		 * since it is not in any of the vdesc lists
> +		 */
> +		edma_desc_free(&echan->edesc->vdesc);
> +
>  		echan->edesc = NULL;
>  		edma_stop(echan->ch_num);
>  		/* Move the cyclic channel back to default queue */
> -- 
> 2.3.3
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/