linux-kernel - Re: [PATCH] genirq: provide dummy set_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150330180645.GC9513@saruman.tx.rr.com>
Date:	Mon, 30 Mar 2015 13:06:45 -0500
From:	Felipe Balbi <balbi@...com>
To:	Felipe Balbi <balbi@...com>
CC:	Roger Quadros <rogerq@...com>, <tglx@...utronix.de>,
	<cw00.choi@...sung.com>, <tony@...mide.com>,
	<linux-usb@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] genirq: provide dummy set_irq_wake()

On Mon, Mar 30, 2015 at 01:06:24PM -0500, Felipe Balbi wrote:
> On Mon, Mar 30, 2015 at 04:15:45PM +0300, Roger Quadros wrote:
> > Without this system suspend is broken on systems that have
> > drivers calling enable/disable_irq_wake() for interrupts based off
> > the dummy irq hook.
> > (e.g. drivers/gpio/gpio-pcf857x.c)
> > 
> > http://article.gmane.org/gmane.linux.kernel/1879035
> > 
> > Signed-off-by: Roger Quadros <rogerq@...com>
> > ---
> >  kernel/irq/dummychip.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c
> > index 988dc58..2405d7a 100644
> > --- a/kernel/irq/dummychip.c
> > +++ b/kernel/irq/dummychip.c
> > @@ -32,6 +32,11 @@ static unsigned int noop_ret(struct irq_data *data)
> >  	return 0;
> >  }
> >  
> > +static int noop_int_ret(struct irq_data *data, unsigned int val)
> > +{
> > +	return 0;
> > +}
> > +
> 
> isn't this the same as noop_ret ?

oh no, unsigned versus signed.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)