linux-kernel - Re: [PATCH 2/5] x86/asm/entry/64: simplify retint_kernel label usage, make retint_restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwQXxMkt_MBFdf6phAxECO9FXJv5+U=FQOiqR7WiUo0+Q@mail.gmail.com>
Date:	Mon, 30 Mar 2015 11:18:45 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Borislav Petkov <bp@...en8.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andy Lutomirski <luto@...capital.net>,
	Oleg Nesterov <oleg@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Will Drewry <wad@...omium.org>,
	Kees Cook <keescook@...omium.org>,
	"the arch/x86 maintainers" <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/5] x86/asm/entry/64: simplify retint_kernel label usage,
 make retint_restore_args label local

On Mon, Mar 30, 2015 at 11:09 AM, Denys Vlasenko <dvlasenk@...hat.com> wrote:
>
> Strip retint_kernel of .global-ness (ENTRY macro) - it has no users
> outside of this file.

The reason for the ENTRY is to get it aligned, not because it's
globally visible. It doesn't have any fallthroughs, and some cpu's
care more than others.

See commit b06babac45e1 ("Add proper alignment to ENTRY").

Not that I'm sure the alignment matters all that much, but I thought
I'd point it out. Removing the ENTRY() does a lot more than just
remote the .globl.

                     Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/