[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5519A689.3040908@gmail.com>
Date: Mon, 30 Mar 2015 13:39:53 -0600
From: David Ahern <dsahern@...il.com>
To: Peter Zijlstra <peterz@...radead.org>
CC: Stephane Eranian <eranian@...gle.com>,
Arnaldo Carvalho de Melo <acme@...hat.com>,
Thomas Gleixner <tglx@...utronix.de>,
Jiri Olsa <jolsa@...hat.com>,
Linus Torvalds <torvalds@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>,
John Stultz <john.stultz@...aro.org>,
"H. Peter Anvin" <hpa@...or.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] perf, record: Add clockid parameter
On 3/30/15 1:32 PM, Peter Zijlstra wrote:
>>> --- a/tools/perf/builtin-record.c
>>> +++ b/tools/perf/builtin-record.c
>>> @@ -732,13 +732,16 @@ static const struct clockid_map clockids
>>> /* available for all events, NMI safe */
>>> CLOCKID_MAP("monotonic", CLOCK_MONOTONIC),
>>> CLOCKID_MAP("monotonic_raw", CLOCK_MONOTONIC_RAW),
>>> - CLOCKID_MAP("raw", CLOCK_MONOTONIC_RAW),
>>>
>>> /* available for some events */
>>> CLOCKID_MAP("realtime", CLOCK_REALTIME),
>>> CLOCKID_MAP("boottime", CLOCK_BOOTTIME),
>>> CLOCKID_MAP("tai", CLOCK_TAI),
>>>
>>> + /* available for the lazy */
>>> + CLOCKID_MAP("mono", CLOCK_MONOTONIC),
>>> + CLOCKID_MAP("raw", CLOCK_MONOTONIC_RAW),
>>> +
>>
>> how about this one as well:
>> CLOCKID_MAP("real", CLOCK_REALTIME),
>
> CLOCK_REALTIME is of limited usability because its not NMI safe.
>
sure, but you have the long version above. I was also suggesting the
shortcut version -- 5 fewer letters.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists