linux-kernel - Re: [PATCH v2] ftracetest: Convert exit -1 to exit $FAIL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Mar 2015 15:50:50 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Michael Ellerman <mpe@...erman.id.au>
Cc:	shuahkh@....samsung.com, <linux-kernel@...r.kernel.org>,
	davej@...emonkey.org.uk, namhyung@...nel.org
Subject: Re: [PATCH v2] ftracetest: Convert exit -1 to exit $FAIL

On Mon, 30 Mar 2015 16:21:00 +1100
Michael Ellerman <mpe@...erman.id.au> wrote:

> POSIX says that exit takes an unsigned integer between 0 and 255, so
> using -1 doesn't work on POSIX shells.
> 
> There is already a well-defined failure code, $FAIL (1), so use that.
> 
> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve

> ---
> 
> v2: Use exit $FAIL not exit 255.
> 
>  tools/testing/selftests/ftrace/test.d/00basic/basic4.tc             | 2 +-
>  tools/testing/selftests/ftrace/test.d/event/event-enable.tc         | 2 +-
>  tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc     | 2 +-
>  tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc      | 2 +-
>  tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc | 2 +-
>  tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc       | 2 +-
>  tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc       | 2 +-
>  7 files changed, 7 insertions(+), 7 deletions(-)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/